Commit d1607dc7 authored by Jens Stimpfle's avatar Jens Stimpfle Committed by Thomas Petazzoni
Browse files

support/scripts/dependencies.sh: improve g++ test to avoid misleading output 



When g++ is not installed, a misleading error message turns up because
of a bad combination of an unquoted shell variable and control flow.

 ~/buildroot$ make
 You may have to install 'g++' on your build machine
 /home/testuser/buildroot/support/dependencies/dependencies.sh: 136: [: -lt: unexpected operator

[Thomas:
  - fixed commit log, as per the suggestion of Yann E. Morin.
  - don't change existing empty new lines, suggested by Yann.
  - use positive logic in the newly added test, suggested by Yann.]

Signed-off-by: default avatarJens Stimpfle <debian@jstimpfle.de>
Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
parent 66056a51

support/dependencies/dependencies.sh

+2 −0
Original line number Diff line number Diff line
@@ -133,7 +133,9 @@ if [ ! -z "$CXXCOMPILER" ] ; then 
		echo

		echo "You may have to install 'g++' on your build machine"

	fi

fi



if [ -n "$CXXCOMPILER_VERSION" ] ; then

	CXXCOMPILER_MAJOR=$(echo $CXXCOMPILER_VERSION | sed -e "s/\..*//g")

	CXXCOMPILER_MINOR=$(echo $CXXCOMPILER_VERSION | sed -e "s/^$CXXCOMPILER_MAJOR\.//g" -e "s/\..*//g")

	if [ $CXXCOMPILER_MAJOR -lt 3 -o $CXXCOMPILER_MAJOR -eq 2 -a $CXXCOMPILER_MINOR -lt 95 ] ; then