Commit 5f5e5f29 authored by Yann E. MORIN's avatar Yann E. MORIN Committed by Peter Korsgaard
Browse files

Makefile: internally use absolute paths to BR2_EXTERNAL 



Using a relative path for BR2_EXTERNAL, and using an external defconfig,
such as in (from a Buildroot top-dir):
    make O=.. BR2_EXTERNAL=.. foo_defconfig

is broken. It is unclear why the %_defconfig rule recurses in that case.

This patch internaly makes BR2_EXTERNAL canonical (ie. makes it an absolute
path), and checks the directory exists.

[Peter: s/relatively/relative/ as suggested by Thomas]
Reported-by: default avatarJérémy Rosen <jeremy.rosen@openwide.fr>
Signed-off-by: default avatar"Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Peter Korsgaard <jacmet@uclibc.org>
Cc: Romain Naour <romain.naour@openwide.fr>
Cc: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: default avatarPeter Korsgaard <peter@korsgaard.com>
parent f0862592

Makefile

+5 −0
Original line number Diff line number Diff line
@@ -119,6 +119,11 @@ ifeq ($(BR2_EXTERNAL),) 
  override BR2_EXTERNAL = support/dummy-external

  $(shell rm -f $(BR2_EXTERNAL_FILE))

else

  _BR2_EXTERNAL = $(shell cd $(BR2_EXTERNAL) >/dev/null 2>&1 && pwd)

  ifeq ($(_BR2_EXTERNAL),)

    $(error BR2_EXTERNAL='$(BR2_EXTERNAL)' does not exist, relative to $(TOPDIR))

  endif

  override BR2_EXTERNAL := $(_BR2_EXTERNAL)

  $(shell echo BR2_EXTERNAL ?= $(BR2_EXTERNAL) > $(BR2_EXTERNAL_FILE))

endif