Commit 22e63d95 authored by Thomas Petazzoni's avatar Thomas Petazzoni
Browse files

apache, apr: fix atomic handling 



Since the apache package was introduced,
--enable-nonportable-atomics=yes was passed when
BR2_ARCH_HAS_ATOMICS. However, Apache doesn't take this option: it
only passes it down when building the APR library. But since we're
building APR separately, this statement had no effect.

So this commit removes the useless code from the Apache package, and
instead adds the appropriate logic to the apr package, using the new
BR2_TOOLCHAIN_HAS_SYNC_x symbols rather than BR2_ARCH_HAS_ATOMICS.

Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: default avatar"Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
parent 7290dc1e

package/apache/apache.mk

+0 −4
Original line number Diff line number Diff line
@@ -35,10 +35,6 @@ APACHE_CONF_OPTS = \ 
	--disable-lua \

	--disable-luajit



ifeq ($(BR2_ARCH_HAS_ATOMICS),y)

APACHE_CONF_OPTS += --enable-nonportable-atomics=yes

endif



ifeq ($(BR2_PACKAGE_LIBXML2),y)

APACHE_DEPENDENCIES += libxml2

# Apache wants the path to the header file, where it can find

package/apr/apr.mk

+15 −0
Original line number Diff line number Diff line
@@ -35,6 +35,21 @@ endif 
# Fix lfs detection when cross compiling

APR_CONF_ENV += apr_cv_use_lfs64=yes



# Use non-portable atomics when available: 8 bytes atomics are used on

# 64-bits architectures, 4 bytes atomics on 32-bits architectures. We

# have to override ap_cv_atomic_builtins because the test used to

# check for atomic builtins uses AC_TRY_RUN, which doesn't work when

# cross-compiling.

ifeq ($(BR2_ARCH_IS_64):$(BR2_TOOLCHAIN_HAS_SYNC_8),y:y)

APR_CONF_OPTS += --enable-nonportable-atomics

APR_CONF_ENV += ap_cv_atomic_builtins=yes

else ifeq ($(BR2_ARCH_IS_64):$(BR2_TOOLCHAIN_HAS_SYNC_4),:y)

APR_CONF_OPTS += --enable-nonportable-atomics

APR_CONF_ENV += ap_cv_atomic_builtins=yes

else

APR_CONF_OPTS += --disable-nonportable-atomics

endif



ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBUUID),y)

APR_DEPENDENCIES += util-linux

endif