Commit 7290dc1e authored by Thomas Petazzoni's avatar Thomas Petazzoni
Browse files

pulseaudio: remove BR2_ARCH_HAS_ATOMICS dependency 



pulseaudio is able to either use the atomic __sync builtins from the
compiler, or to rely on libatomic_ops for atomic operations. However,
since it anyway selects json-c which requires the __sync built-ins, it
means using libatomic_ops is useless: even if you use libatomic_ops
for pulseaudio, you'd still get a link error in pulseaudio due to the
missing __sync built-in for the json-c library.

Also, since pulseaudio now inherits the BR2_TOOLCHAIN_HAS_SYNC_4 from
json-c, which matches the __sync built-in from pulseaudio, this
commit:

 - Drops the BR2_ARCH_HAS_ATOMICS dependency
 - Forces pulseaudio to not detect libatomic_ops
 - Propagates the removal of BR2_ARCH_HAS_ATOMICS dependency to
   pulseaudio's reverse dependencies.

Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: default avatar"Yann E. MORIN" <yann.morin.1998@free.fr>
parent 8ea392b8

package/efl/Config.in

+0 −1
Original line number Diff line number Diff line
@@ -81,7 +81,6 @@ config BR2_PACKAGE_EFL_LIBSNDFILE 


config BR2_PACKAGE_EFL_PULSEAUDIO

	bool "Enable pulseaudio support (recommended)"

	depends on BR2_ARCH_HAS_ATOMICS # pulseaudio

	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pulseaudio -> json-c

	select BR2_PACKAGE_PULSEAUDIO

	default y

package/espeak/Config.in

+0 −1
Original line number Diff line number Diff line
@@ -32,7 +32,6 @@ config BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_ALSA 


config BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_PULSEAUDIO

	bool "pulseaudio"

	depends on BR2_ARCH_HAS_ATOMICS # pulseaudio

	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pulseaudio -> json-c

	select BR2_PACKAGE_PULSEAUDIO

package/gstreamer/gst-plugins-good/Config.in

+0 −2
Original line number Diff line number Diff line
@@ -204,7 +204,6 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_OSS4 
config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PULSE

	depends on BR2_TOOLCHAIN_HAS_THREADS # pulseaudio

	depends on BR2_USE_MMU # pulseaudio

	depends on BR2_ARCH_HAS_ATOMICS # pulseaudio

	depends on !BR2_STATIC_LIBS # pulseaudio

	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pulseaudio -> json-c

	select BR2_PACKAGE_PULSEAUDIO
@@ -212,7 +211,6 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PULSE 


comment "pulseaudio support needs a toolchain w/ threads, dynamic library"

	depends on BR2_USE_MMU

	depends on BR2_ARCH_HAS_ATOMICS

	depends on BR2_TOOLCHAIN_HAS_SYNC_4

	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS

package/gstreamer1/gst1-plugins-good/Config.in

+0 −2
Original line number Diff line number Diff line
@@ -311,7 +311,6 @@ comment "gdkpixbuf needs a toolchain w/ wchar, threads" 
config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_PULSE

	depends on BR2_TOOLCHAIN_HAS_THREADS # pulseaudio

	depends on BR2_USE_MMU # pulseaudio

	depends on BR2_ARCH_HAS_ATOMICS # pulseaudio

	depends on !BR2_STATIC_LIBS # pulseaudio

	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pulseaudio -> json-c

	select BR2_PACKAGE_PULSEAUDIO
@@ -321,7 +320,6 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_PULSE 


comment "pulseaudio support needs a toolchain w/ threads, dynamic library"

	depends on BR2_USE_MMU

	depends on BR2_ARCH_HAS_ATOMICS

	depends on BR2_TOOLCHAIN_HAS_SYNC_4

	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS

package/mpd/Config.in

+0 −1
Original line number Diff line number Diff line
@@ -250,7 +250,6 @@ config BR2_PACKAGE_MPD_OSS 


config BR2_PACKAGE_MPD_PULSEAUDIO

	bool "pulseaudio"

	depends on BR2_ARCH_HAS_ATOMICS # pulseaudio

	depends on !BR2_STATIC_LIBS # pulseaudio

	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pulseaudio -> json-c

	select BR2_PACKAGE_PULSEAUDIO