Commit e3f6d8df authored by Sergey Biryukov's avatar Sergey Biryukov
Browse files

Plugins: Move the "Successfully installed the plugin" string to the correct... 

Plugins: Move the "Successfully installed the plugin" string to the correct `Plugin_Upgrader` method.

The string refers to the installation, and belongs in the `::install_strings()` method, not in `::upgrade_strings()`.

Props sswebster, nateinaction.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48734] to the 5.5 branch.
Fixes #50837.
Built from https://develop.svn.wordpress.org/branches/5.5@48735


git-svn-id: https://core.svn.wordpress.org/branches/5.5@48497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
parent cd28922c

wp-admin/includes/class-plugin-upgrader.php

+2 −3
Original line number Diff line number Diff line
@@ -64,9 +64,6 @@ class Plugin_Upgrader extends WP_Upgrader { 
		$this->strings['process_failed']       = __( 'Plugin update failed.' );

		$this->strings['process_success']      = __( 'Plugin updated successfully.' );

		$this->strings['process_bulk_success'] = __( 'Plugins updated successfully.' );



		/* translators: 1: Plugin name, 2: Plugin version. */

		$this->strings['process_success_specific'] = __( 'Successfully installed the plugin <strong>%1$s %2$s</strong>.' );

	}



	/**
@@ -85,6 +82,8 @@ class Plugin_Upgrader extends WP_Upgrader { 
		$this->strings['no_files']            = __( 'The plugin contains no files.' );

		$this->strings['process_failed']      = __( 'Plugin installation failed.' );

		$this->strings['process_success']     = __( 'Plugin installed successfully.' );

		/* translators: 1: Plugin name, 2: Plugin version. */

		$this->strings['process_success_specific'] = __( 'Successfully installed the plugin <strong>%1$s %2$s</strong>.' );



		if ( ! empty( $this->skin->overwrite ) ) {

			if ( 'update-plugin' === $this->skin->overwrite ) {

wp-admin/includes/class-theme-upgrader.php

+1 −1
Original line number Diff line number Diff line
@@ -163,7 +163,7 @@ class Theme_Upgrader extends WP_Upgrader { 
		// Override them.

		$this->skin->api = $api;



		$this->strings['process_success_specific'] = $this->strings['parent_theme_install_success']; //, $api->name, $api->version );

		$this->strings['process_success_specific'] = $this->strings['parent_theme_install_success'];



		$this->skin->feedback( 'parent_theme_prepare_install', $api->name, $api->version );

wp-includes/version.php

+1 −1
Original line number Diff line number Diff line
@@ -13,7 +13,7 @@ 
 *

 * @global string $wp_version

 */

$wp_version = '5.5-RC1-48733';

$wp_version = '5.5-RC1-48735';



/**

 * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.