Commit fb9ac572 authored by Jacob Kaplan-Moss's avatar Jacob Kaplan-Moss
Browse files

Fixed #10153: foreign key `gte` and `lte` lookups now work. Thanks, joelhooks and adurdin. 

git-svn-id: http://code.djangoproject.com/svn/django/trunk@10692 bcc190cf-cafb-0310-a4f2-bffc1f526a37
parent bfdb7d26

django/db/models/fields/related.py

+1 −1
Original line number Diff line number Diff line
@@ -155,7 +155,7 @@ class RelatedField(object): 
        # get_(next/prev)_by_date work; other lookups are not allowed since that

        # gets messy pretty quick. This is a good candidate for some refactoring

        # in the future.

        if lookup_type in ['exact', 'gt', 'lt']:

        if lookup_type in ['exact', 'gt', 'lt', 'gte', 'lte']:

            return [pk_trace(value)]

        if lookup_type in ('range', 'in'):

            return [pk_trace(v) for v in value]

tests/regressiontests/model_regress/tests.py

0 → 100644
+16 −0
Original line number Diff line number Diff line 
from models import Worker

from django.test import TestCase



class RelatedModelOrderedLookupTest(TestCase):

    """

    Regression test for #10153: foreign key __gte and __lte lookups.

    """

    

    # The bug is that the following queries would raise:

    # "TypeError: Related Field has invalid lookup: gte"

    

    def test_related_gte_lookup(self):

        Worker.objects.filter(department__gte=0)



    def test_related_lte_lookup(self):

        Worker.objects.filter(department__lte=0)