Commit fa534b92 authored by Thomas Chaumeny's avatar Thomas Chaumeny Committed by Tim Graham
Browse files

Fixed #23623 -- Reduced memory consumption when generating ModelChoiceField choices

parent 115c3071
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -1083,12 +1083,12 @@ class ModelChoiceIterator(object):
        if self.field.cache_choices:
            if self.field.choice_cache is None:
                self.field.choice_cache = [
                    self.choice(obj) for obj in self.queryset.all()
                    self.choice(obj) for obj in self.queryset.iterator()
                ]
            for choice in self.field.choice_cache:
                yield choice
        else:
            for obj in self.queryset.all():
            for obj in self.queryset.iterator():
                yield self.choice(obj)

    def __len__(self):