Commit f4e98045 authored by Claude Paroz's avatar Claude Paroz
Browse files

Fixed #20961 -- Fixed HttpResponse default empty content 

Thanks epandurski at gmail.com for the report.
parent f33db5a0

django/http/response.py

+1 −1
Original line number Diff line number Diff line
@@ -317,7 +317,7 @@ class HttpResponse(HttpResponseBase): 


    streaming = False



    def __init__(self, content='', *args, **kwargs):

    def __init__(self, content=b'', *args, **kwargs):

        super(HttpResponse, self).__init__(*args, **kwargs)

        # Content is a bytestring. See the `content` property methods.

        self.content = content

tests/httpwrappers/tests.py

+7 −0
Original line number Diff line number Diff line
@@ -385,6 +385,13 @@ class HttpResponseTests(unittest.TestCase): 
        self.assertEqual(r.tell(), 6)

        self.assertEqual(r.content, b'abcdef')



        # with Content-Encoding header

        r = HttpResponse()

        r['Content-Encoding'] = 'winning'

        r.write(b'abc')

        r.write(b'def')

        self.assertEqual(r.content, b'abcdef')



    def test_unsafe_redirect(self):

        bad_urls = [

            'data:text/html,<script>window.alert("xss")</script>',