Commit c6e0dedb authored by Claude Paroz's avatar Claude Paroz
Browse files

Fixed #19637 -- Ensured AdminEmailHandler fails silently 

Thanks lsaffre for the report. Refs #19325.
parent 7aa53835

django/utils/log.py

+1 −1
Original line number Diff line number Diff line
@@ -117,7 +117,7 @@ class AdminEmailHandler(logging.Handler): 
                         connection=self.connection())



    def connection(self):

        return get_connection(backend=self.email_backend)

        return get_connection(backend=self.email_backend, fail_silently=True)



    def format_subject(self, subject):

        """

tests/regressiontests/logging_tests/tests.py

+4 −0
Original line number Diff line number Diff line
@@ -154,6 +154,10 @@ class AdminEmailHandlerTest(TestCase): 
            ][0]

        return admin_email_handler



    def test_fail_silently(self):

        admin_email_handler = self.get_admin_email_handler(self.logger)

        self.assertTrue(admin_email_handler.connection().fail_silently)



    @override_settings(

            ADMINS=(('whatever admin', 'admin@example.com'),),

            EMAIL_SUBJECT_PREFIX='-SuperAwesomeSubject-'