Commit c3054716 authored by Malcolm Tredinnick's avatar Malcolm Tredinnick
Browse files

Fixed get_absolute_url() for comments. Previously, it relied on "view on site" 

for admin being reversible or required people to set up their own version. Now
we ship a default pattern in the comments URLs in a way that is unlikely to
clash with anything else.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@8614 bcc190cf-cafb-0310-a4f2-bffc1f526a37
parent 157dbe2f

django/contrib/comments/models.py

+2 −3
Original line number Diff line number Diff line
@@ -30,11 +30,10 @@ class BaseCommentAbstractModel(models.Model): 


    def get_content_object_url(self):

        """

        Get a URL suitable for redirecting to the content object. Uses the

        ``django.views.defaults.shortcut`` view, which thus must be installed.

        Get a URL suitable for redirecting to the content object.

        """

        return urlresolvers.reverse(

            "django.views.defaults.shortcut",

            "comments-url-redirect",

            args=(self.content_type_id, self.object_pk)

        )

django/contrib/comments/urls.py

+4 −0
Original line number Diff line number Diff line
@@ -13,3 +13,7 @@ urlpatterns = patterns('django.contrib.comments.views', 
    url(r'^approved/$',      'moderation.approve_done',     name='comments-approve-done'),

)



urlpatterns += patterns('',

    url(r'^cr/(\d+)/(\w+)/$', 'django.views.defaults.shortcut', name='comments-url-redirect'),

)