Commit c0b53b3d authored by Malcolm Tredinnick's avatar Malcolm Tredinnick
Browse files

Removed the need for ROOT_URLCONF in settings when running Django's core tests 

(via runtests.py). It was embarrassing having to explain the need for it to
people, since we ignore whatever setting is passed in.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@8731 bcc190cf-cafb-0310-a4f2-bffc1f526a37
parent fd0cc458

docs/internals/contributing.txt

+1 −2
Original line number Diff line number Diff line
@@ -730,8 +730,7 @@ To run the tests, ``cd`` to the ``tests/`` directory and type: 
    ./runtests.py --settings=path.to.django.settings



Yes, the unit tests need a settings module, but only for database connection

info, with the ``DATABASE_ENGINE`` setting. You'll also need a ``ROOT_URLCONF``

setting (its value is ignored; it just needs to be present).

info, with the ``DATABASE_ENGINE`` setting.



If you're using the ``sqlite3`` database backend, no further settings are

needed. A temporary database will be created in memory when running the tests.

tests/runtests.py

+1 −1
Original line number Diff line number Diff line
@@ -90,7 +90,7 @@ def django_tests(verbosity, interactive, test_labels): 


    old_installed_apps = settings.INSTALLED_APPS

    old_test_database_name = settings.TEST_DATABASE_NAME

    old_root_urlconf = settings.ROOT_URLCONF

    old_root_urlconf = getattr(settings, "ROOT_URLCONF", "")

    old_template_dirs = settings.TEMPLATE_DIRS

    old_use_i18n = settings.USE_I18N

    old_login_url = settings.LOGIN_URL