Commit ade98599 authored by Tim Graham's avatar Tim Graham
Browse files

Fixed #24095 -- Prevented WarningLoggerTests from leaking a warnings filter.

parent 862ea825

tests/logging_tests/tests.py

+10 −7
Original line number Diff line number Diff line
@@ -101,7 +101,6 @@ class WarningLoggerTests(TestCase): 
        # undocumented and (I assume) brittle.

        self._old_capture_state = bool(getattr(logging, '_warnings_showwarning', False))

        logging.captureWarnings(True)

        warnings.filterwarnings('always')



        # this convoluted setup is to avoid printing this deprecation to

        # stderr during test running - as the test runner forces deprecations
@@ -123,11 +122,15 @@ class WarningLoggerTests(TestCase): 


    @override_settings(DEBUG=True)

    def test_warnings_capture(self):

        with warnings.catch_warnings():

            warnings.filterwarnings('always')

            warnings.warn('Foo Deprecated', RemovedInNextVersionWarning)

            output = force_text(self.outputs[0].getvalue())

            self.assertIn('Foo Deprecated', output)



    def test_warnings_capture_debug_false(self):

        with warnings.catch_warnings():

            warnings.filterwarnings('always')

            warnings.warn('Foo Deprecated', RemovedInNextVersionWarning)

            output = force_text(self.outputs[0].getvalue())

            self.assertNotIn('Foo Deprecated', output)