Commit adcf8233 authored by Kaleb Elwert's avatar Kaleb Elwert Committed by Tim Graham
Browse files

Fixed #25490 -- Made the logout() view send "no-cache" headers.

parent 37a5a363

django/contrib/auth/views.py

+1 −0
Original line number Diff line number Diff line
@@ -92,6 +92,7 @@ def login(request, template_name='registration/login.html', 




@deprecate_current_app

@never_cache

def logout(request, next_page=None,

           template_name='registration/logged_out.html',

           redirect_field_name=REDIRECT_FIELD_NAME,

docs/releases/1.10.txt

+4 −0
Original line number Diff line number Diff line
@@ -47,6 +47,10 @@ Minor features 
  subclassed ``django.contrib.auth.hashers.PBKDF2PasswordHasher`` to change the

  default value.



* The :func:`~django.contrib.auth.views.logout` view sends "no-cache" headers

  to prevent an issue where Safari caches redirects and prevents a user from

  being able to log out.



:mod:`django.contrib.contenttypes`

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

tests/auth_tests/test_views.py

+8 −0
Original line number Diff line number Diff line
@@ -770,6 +770,14 @@ class LogoutTest(AuthViewsTestCase): 
        response = self.client.get('/logout/')

        self.assertIn('site', response.context)



    def test_logout_doesnt_cache(self):

        """

        The logout() view should send "no-cache" headers for reasons described

        in #25490.

        """

        response = self.client.get('/logout/')

        self.assertIn('no-store', response['Cache-Control'])



    def test_logout_with_overridden_redirect_url(self):

        # Bug 11223

        self.login()