Commit a9e188cc authored by Christopher Grebs's avatar Christopher Grebs Committed by Tim Graham
Browse files

Fixed #26119 -- Fixed URLValidator crash on URLs with brackets.

parent 7ca6007b

django/core/validators.py

+4 −1
Original line number Diff line number Diff line
@@ -124,7 +124,10 @@ class URLValidator(RegexValidator): 
        except ValidationError as e:

            # Trivial case failed. Try for possible IDN domain

            if value:

                try:

                    scheme, netloc, path, query, fragment = urlsplit(value)

                except ValueError:  # for example, "Invalid IPv6 URL"

                    raise ValidationError(self.message, code=self.code)

                try:

                    netloc = netloc.encode('idna').decode('ascii')  # IDN -> ACE

                except UnicodeError:  # invalid domain part

tests/validators/invalid_urls.txt

+1 −0
Original line number Diff line number Diff line
@@ -56,3 +56,4 @@ http://aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.example. 
http://example.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.com

http://example.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

http://aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaaaaa

https://test.[com