Commit a7639722 authored by Baptiste Mispelon's avatar Baptiste Mispelon
Browse files

Fixed #7423 -- Skip superuser creation when not running in a TTY. 

Thanks to trac user galaxy4sale for the original report
and to AeroNotix for the patch.
parent 81cd3a74

django/contrib/auth/management/commands/createsuperuser.py

+20 −5
Original line number Diff line number Diff line
@@ -17,6 +17,10 @@ from django.utils.six.moves import input 
from django.utils.text import capfirst





class NotRunningInTTYException(Exception):

    pass





class Command(BaseCommand):



    def __init__(self, *args, **kwargs):
@@ -80,6 +84,9 @@ class Command(BaseCommand): 
            default_username = get_default_username()

            try:



                if not self.stdin.isatty():

                    raise NotRunningInTTYException("Not running in a TTY")



                # Get a username

                verbose_field_name = self.username_field.verbose_name

                while username is None:
@@ -136,6 +143,14 @@ class Command(BaseCommand): 
                self.stderr.write("\nOperation cancelled.")

                sys.exit(1)



            except NotRunningInTTYException:

                self.stdout.write(

                    "Superuser creation skipped due to not running in a TTY. "

                    "You can run `manage.py createsuperuser` in your project "

                    "to create one manually."

                )



        if username:

            user_data[self.UserModel.USERNAME_FIELD] = username

            user_data['password'] = password

            self.UserModel._default_manager.db_manager(database).create_superuser(**user_data)

django/contrib/auth/tests/test_management.py

+21 −0
Original line number Diff line number Diff line
@@ -191,6 +191,27 @@ class CreatesuperuserManagementCommandTestCase(TestCase): 


        self.assertEqual(CustomUser._default_manager.count(), 0)



    def test_skip_if_not_in_TTY(self):

        """

        If the command is not called from a TTY, it should be skipped and a

        message should be displayed (#7423).

        """

        class FakeStdin(object):

            """A fake stdin object that has isatty() return False."""

            def isatty(self):

                return False



        out = StringIO()

        call_command(

            "createsuperuser",

            stdin=FakeStdin(),

            stdout=out,

            interactive=True,

        )



        self.assertEqual(User._default_manager.count(), 0)

        self.assertIn("Superuser creation skipped", out.getvalue())





class CustomUserModelValidationTestCase(TestCase):

    @override_settings(AUTH_USER_MODEL='auth.CustomUserNonListRequiredFields')