Commit 8599f64e authored by Claude Paroz's avatar Claude Paroz
Browse files

Fixed #18861 -- Triggered message validation with locmem email backend 

Thanks Bruno Renié for the report and the initial patch.
parent 0ab8c58c

django/core/mail/backends/locmem.py

+2 −0
Original line number Diff line number Diff line
@@ -20,5 +20,7 @@ class EmailBackend(BaseEmailBackend): 


    def send_messages(self, messages):

        """Redirect messages to the dummy outbox"""

        for message in messages:  # .message() triggers header validation

            message.message()

        mail.outbox.extend(messages)

        return len(messages)

tests/regressiontests/mail/tests.py

+5 −0
Original line number Diff line number Diff line
@@ -498,6 +498,11 @@ class LocmemBackendTests(BaseEmailBackendTests, TestCase): 
        connection2.send_messages([email])

        self.assertEqual(len(mail.outbox), 2)



    def test_validate_multiline_headers(self):

        # Ticket #18861 - Validate emails when using the locmem backend

        with self.assertRaises(BadHeaderError):

            send_mail('Subject\nMultiline', 'Content', 'from@example.com', ['to@example.com'])





class FileBackendTests(BaseEmailBackendTests, TestCase):

    email_backend = 'django.core.mail.backends.filebased.EmailBackend'