Commit 8287c27b authored by Justin Bronn's avatar Justin Bronn
Browse files

Fixed #12101 -- `OGRGeometry` does not need to create a clone of the... 

Fixed #12101 -- `OGRGeometry` does not need to create a clone of the `SpatialReference` object upon assignment.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@11707 bcc190cf-cafb-0310-a4f2-bffc1f526a37
parent 5dfed1b2

django/contrib/gis/gdal/geometries.py

+6 −2
Original line number Diff line number Diff line
@@ -256,11 +256,15 @@ class OGRGeometry(GDALBase): 


    def _set_srs(self, srs):

        "Sets the SpatialReference for this geometry."

        # Do not have to clone the `SpatialReference` object pointer because

        # when it is assigned to this `OGRGeometry` it's internal OGR

        # reference count is incremented, and will likewise be released

        # (decremented) when this geometry's destructor is called.

        if isinstance(srs, SpatialReference):

            srs_ptr = srs_api.clone_srs(srs.ptr)

            srs_ptr = srs.ptr

        elif isinstance(srs, (int, long, basestring)):

            sr = SpatialReference(srs)

            srs_ptr = srs_api.clone_srs(sr.ptr)

            srs_ptr = sr.ptr

        else:

            raise TypeError('Cannot assign spatial reference with object of type: %s' % type(srs))

        capi.assign_srs(self.ptr, srs_ptr)