Commit 7db770b0 authored by Aymeric Augustin's avatar Aymeric Augustin
Browse files

Added a check in the creation of IS NULL clauses. 

value_annotation isn't very well defined. Before this change, setting it
to datetime.datetime could silently reverse the behavior of isnull
lookups. This commit doesn't have any consequences on the current code.
It's just a safeguard for future ORM hackers.
parent a10f3908

django/db/models/sql/where.py

+2 −2
Original line number Diff line number Diff line
@@ -225,8 +225,8 @@ class WhereNode(tree.Node): 
            return ('%s = %%s' % connection.ops.date_extract_sql(lookup_type, field_sql),

                    params)

        elif lookup_type == 'isnull':

            return ('%s IS %sNULL' % (field_sql,

                (not value_annotation and 'NOT ' or '')), ())

            assert value_annotation in (True, False), "Invalid value_annotation for isnull"

            return ('%s IS %sNULL' % (field_sql, ('' if value_annotation else 'NOT ')), ())

        elif lookup_type == 'search':

            return (connection.ops.fulltext_search_sql(field_sql), params)

        elif lookup_type in ('regex', 'iregex'):