Commit 77f50c9c authored by Tim Graham's avatar Tim Graham
Browse files

Fixed #25948 -- Added guidelines for SimpleTestCase.assertRaisesMessage() usage.

parent 0224f1cb
Loading
Loading
Loading
Loading
+6 −0
Original line number Diff line number Diff line
@@ -45,6 +45,12 @@ Python style
          """
          ...

* In tests, use :meth:`~django.test.SimpleTestCase.assertRaisesMessage` instead
  of :meth:`~unittest.TestCase.assertRaises` so you can check the exception
  message. Use :meth:`~unittest.TestCase.assertRaisesRegex`
  (``six.assertRaisesRegex()`` as long as we support Python 2) only if you need
  to use regular expression matching.

Imports
-------

+3 −3
Original line number Diff line number Diff line
@@ -1345,9 +1345,9 @@ your test suite.

    Asserts that execution of ``callable`` raises ``expected_exception`` and
    that ``expected_message`` is found in the exception's message. Any other
    outcome is reported as a failure. Similar to unittest's
    :meth:`~unittest.TestCase.assertRaisesRegex` with the difference that
    ``expected_message`` isn't a regular expression.
    outcome is reported as a failure. It's a simpler version of
    :meth:`unittest.TestCase.assertRaisesRegex` with the difference that
    ``expected_message`` isn't treated as a regular expression.

    If only the ``expected_exception`` and ``expected_message`` parameters are
    given, returns a context manager so that the code being tested can be