Commit 69337d48 authored by Shai Berger's avatar Shai Berger
Browse files

Set straight the sense of 'uppercases_column_names' feature flag

parent 7e3cf3cf

django/db/backends/__init__.py

+1 −1
Original line number Diff line number Diff line
@@ -649,7 +649,7 @@ class BaseDatabaseFeatures(object): 
    # If NULL is implied on columns without needing to be explicitly specified

    implied_column_null = False



    uppercases_column_names = True

    uppercases_column_names = False



    def __init__(self, connection):

        self.connection = connection

django/db/backends/oracle/base.py

+1 −1
Original line number Diff line number Diff line
@@ -120,7 +120,7 @@ class DatabaseFeatures(BaseDatabaseFeatures): 
    connection_persists_old_columns = True

    closed_cursor_error_class = InterfaceError

    bare_select_suffix = " FROM DUAL"

    uppercases_column_names = False

    uppercases_column_names = True





class DatabaseOperations(BaseDatabaseOperations):

tests/inspectdb/tests.py

+1 −1
Original line number Diff line number Diff line
@@ -176,7 +176,7 @@ class InspectDBTestCase(TestCase): 
        out = StringIO()

        call_command('inspectdb', stdout=out)

        output = out.getvalue()

        base_name = 'field' if not connection.features.uppercases_column_names else 'Field'

        base_name = 'Field' if not connection.features.uppercases_column_names else 'field'

        self.assertIn("field = models.IntegerField()", output)

        self.assertIn("field_field = models.IntegerField(db_column='%s_')" % base_name, output)

        self.assertIn("field_field_0 = models.IntegerField(db_column='%s__')" % base_name, output)