Commit 6849c5f3 authored by Luke Plant's avatar Luke Plant
Browse files

[1.2.X] Fixed sending mail on 404s to fail silently. 

A failure in the e-mail system should not turn a 404 into a 500.

Backport of [15145] from trunk.

git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.2.X@15146 bcc190cf-cafb-0310-a4f2-bffc1f526a37
parent 0b0e9457

django/middleware/common.py

+2 −1
Original line number Diff line number Diff line
@@ -94,7 +94,8 @@ class CommonMiddleware(object): 
                    ip = request.META.get('REMOTE_ADDR', '<none>')

                    mail_managers("Broken %slink on %s" % ((is_internal and 'INTERNAL ' or ''), domain),

                        "Referrer: %s\nRequested URL: %s\nUser agent: %s\nIP address: %s\n" \

                                  % (referer, request.get_full_path(), ua, ip))

                                  % (referer, request.get_full_path(), ua, ip),

                                  fail_silently=True)

                return response



        # Use ETags, if requested.