Commit 6508db2f authored by Moayad Mardini's avatar Moayad Mardini
Browse files

Fixed #23088 -- Used `six` `range` type in `Paginator.page_range`.

parent bb395a15

django/core/paginator.py

+1 −1
Original line number Diff line number Diff line
@@ -96,7 +96,7 @@ class Paginator(object): 
        Returns a 1-based range of pages for iterating through within

        a template for loop.

        """

        return range(1, self.num_pages + 1)

        return six.moves.range(1, self.num_pages + 1)

    page_range = property(_get_page_range)

tests/pagination/tests.py

+7 −0
Original line number Diff line number Diff line
@@ -232,6 +232,13 @@ class PaginationTests(unittest.TestCase): 
        self.assertEqual(page2.previous_page_number(), 1)

        self.assertIsNone(page2.next_page_number())



    def test_page_range_type(self):

        """

        Ticket #23088: Paginator.page_range is of inconsistent type in Py2/Py3

        """

        paginator = Paginator([1, 2, 3], 2)

        self.assertEqual(type(paginator.page_range), six.moves.range)





class ModelPaginationTests(TestCase):

    """