Commit 64cdea68 authored by Ramiro Morales's avatar Ramiro Morales
Browse files

Report wrongly-typed settings and abort, as originally planned.

Thanks Claude for the heads up. Refs #12493 and commit 5e08b792.
parent 5e3a6532
Loading
Loading
Loading
Loading
+8 −0
Original line number Diff line number Diff line
@@ -132,9 +132,17 @@ class Settings(BaseSettings):
                % (self.SETTINGS_MODULE, e)
            )

        tuple_settings = ("INSTALLED_APPS", "TEMPLATE_DIRS")

        for setting in dir(mod):
            if setting == setting.upper():
                setting_value = getattr(mod, setting)

                if setting in tuple_settings and \
                        isinstance(setting_value, six.string_types):
                    raise ImproperlyConfigured("The %s setting must be a tuple. "
                            "Please fix your settings." % setting)

                setattr(self, setting, setting_value)

        if not self.SECRET_KEY: