Commit 57bb10e6 authored by Malcolm Tredinnick's avatar Malcolm Tredinnick
Browse files

Refactored the HTTP 500 error response creation slightly. Provides the ability 

for subclassing that piece of the processing path.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@7928 bcc190cf-cafb-0310-a4f2-bffc1f526a37
parent e7e4b8b0

django/core/handlers/base.py

+30 −16
Original line number Diff line number Diff line
@@ -60,7 +60,6 @@ class BaseHandler(object): 
    def get_response(self, request):

        "Returns an HttpResponse object for the given HttpRequest"

        from django.core import exceptions, urlresolvers

        from django.core.mail import mail_admins

        from django.conf import settings



        # Apply request middleware
@@ -122,10 +121,25 @@ class BaseHandler(object): 


            if settings.DEBUG_PROPAGATE_EXCEPTIONS:

                raise

            elif settings.DEBUG:

            return self.handle_uncaught_exception(request, resolver, exc_info)



    def handle_uncaught_exception(self, request, resolver, exc_info):

        """

        Processing for any otherwise uncaught exceptions (those that will

        generate HTTP 500 responses). Can be overridden by subclasses who want

        customised 500 handling.



        Be *very* careful when overriding this because the error could be

        caused by anything, so assuming something like the database is always

        available would be an error.

        """

        from django.conf import settings

        from django.core.mail import mail_admins



        if settings.DEBUG:

            from django.views import debug

            return debug.technical_500_response(request, *exc_info)

            else:



        # When DEBUG is False, send an error message to the admins.

        subject = 'Error (%s IP): %s' % ((request.META.get('REMOTE_ADDR') in settings.INTERNAL_IPS and 'internal' or 'EXTERNAL'), request.path)

        try: