Commit 51836756 authored by Malcolm Tredinnick's avatar Malcolm Tredinnick
Browse files

Fixed a typo from the refactoring in [8455]. With bonus test, too. Thanks, vung. 


git-svn-id: http://code.djangoproject.com/svn/django/trunk@8724 bcc190cf-cafb-0310-a4f2-bffc1f526a37
parent 38362a12

django/db/models/query.py

+1 −1
Original line number Diff line number Diff line
@@ -737,7 +737,7 @@ class DateQuerySet(QuerySet): 
        self.query.select = []

        field = self.model._meta.get_field(self._field_name, many_to_many=False)

        assert isinstance(field, DateField), "%r isn't a DateField." \

                % field_name

                % field.name

        self.query.add_date_select(field, self._kind, self._order)

        if field.null:

            self.query.add_filter(('%s__isnull' % field.name, False))

tests/regressiontests/queries/models.py

+6 −0
Original line number Diff line number Diff line
@@ -901,6 +901,12 @@ Pickling of DateQuerySets used to fail 
>>> qs = Item.objects.dates('created', 'month')

>>> _ = pickle.loads(pickle.dumps(qs))



Bug #8683 -- raise proper error when a DateQuerySet gets passed a wrong type of field

>>> Item.objects.dates('name', 'month')

Traceback (most recent call last):

...

AssertionError: 'name' isn't a DateField.



Bug #8597: regression tests for case-insensitive comparisons

>>> _ = Item.objects.create(name="a_b", created=datetime.datetime.now(), creator=a2, note=n1)

>>> _ = Item.objects.create(name="x%y", created=datetime.datetime.now(), creator=a2, note=n1)