Commit 4fe6824f authored by Claude Paroz's avatar Claude Paroz
Browse files

Fixed #23679 -- Fixed null introspection for char/text fields 

Thanks Paul Dejean for the report.
parent 2118aa8a

django/core/management/commands/inspectdb.py

+1 −2
Original line number Diff line number Diff line
@@ -123,7 +123,6 @@ class Command(BaseCommand): 
                            field_type = 'NullBooleanField('

                        else:

                            extra_params['blank'] = True

                            if field_type not in ('TextField(', 'CharField('):

                            extra_params['null'] = True



                    field_desc = '%s = %s%s' % (

tests/inspectdb/models.py

+1 −0
Original line number Diff line number Diff line
@@ -50,6 +50,7 @@ class ColumnTypes(models.Model): 
    bool_field = models.BooleanField(default=False)

    null_bool_field = models.NullBooleanField()

    char_field = models.CharField(max_length=10)

    null_char_field = models.CharField(max_length=10, blank=True, null=True)

    comma_separated_int_field = models.CommaSeparatedIntegerField(max_length=99)

    date_field = models.DateField()

    date_time_field = models.DateTimeField()

tests/inspectdb/tests.py

+1 −0
Original line number Diff line number Diff line
@@ -51,6 +51,7 @@ class InspectDBTestCase(TestCase): 
        if (connection.features.can_introspect_max_length and

                not connection.features.interprets_empty_strings_as_nulls):

            assertFieldType('char_field', "models.CharField(max_length=10)")

            assertFieldType('null_char_field', "models.CharField(max_length=10, blank=True, null=True)")

            assertFieldType('comma_separated_int_field', "models.CharField(max_length=99)")

        assertFieldType('date_field', "models.DateField()")

        assertFieldType('date_time_field', "models.DateTimeField()")