Commit 404870ee authored by Aymeric Augustin's avatar Aymeric Augustin
Browse files

Fixed #20724 -- Test failure on SQLite. 

This test failure happened if the connection's NAME was set to a file
system path, and its TEST_NAME wasn't.

Thanks Claude for the report.
parent 38bc581b

tests/requests/tests.py

+1 −1
Original line number Diff line number Diff line
@@ -679,7 +679,7 @@ class RequestsTests(SimpleTestCase): 




@skipIf(connection.vendor == 'sqlite'

        and connection.settings_dict['NAME'] in ('', ':memory:'),

        and connection.settings_dict['TEST_NAME'] in (None, '', ':memory:'),

        "Cannot establish two connections to an in-memory SQLite database.")

class DatabaseConnectionHandlingTests(TransactionTestCase):

tests/transactions_regress/tests.py

+3 −4
Original line number Diff line number Diff line
@@ -191,10 +191,9 @@ class TestTransactionClosing(IgnoreDeprecationWarningsMixin, TransactionTestCase 
        """

        self.test_failing_query_transaction_closed()



@skipIf(connection.vendor == 'sqlite' and

        (connection.settings_dict['NAME'] == ':memory:' or

         not connection.settings_dict['NAME']),

        'Test uses multiple connections, but in-memory sqlite does not support this')

@skipIf(connection.vendor == 'sqlite'

        and connection.settings_dict['TEST_NAME'] in (None, '', ':memory:'),

        "Cannot establish two connections to an in-memory SQLite database.")

class TestNewConnection(IgnoreDeprecationWarningsMixin, TransactionTestCase):

    """

    Check that new connections don't have special behaviour.