Commit 3411af3c authored by Shai Berger's avatar Shai Berger
Browse files

Fixed #21403: Corrected test code 

A test for annotations incorrectly assumed that the first instance
(in the test) of a model using AutoField for PK will always get pk=1.
The test was changed to compare against actual instance id instead.
parent 70e61310

tests/generic_relations_regress/tests.py

+3 −3
Original line number Diff line number Diff line
@@ -222,10 +222,10 @@ class GenericRelationTests(TestCase): 
        Link.objects.create(content_object=b)

        qs = HasLinkThing.objects.annotate(Sum('links'))

        # If content_type restriction isn't in the query's join condition,

        # then wrong results are produced here as b will also match (it has

        # same pk).

        # then wrong results are produced here as the link to b will also match

        # (b and hs1 have equal pks).

        self.assertEqual(qs.count(), 1)

        self.assertEqual(qs[0].links__sum, 1)

        self.assertEqual(qs[0].links__sum, l.id)

        l.delete()

        # Now if we don't have proper left join, we will not produce any

        # results at all here.