Commit 23b0d636 authored by Baptiste Mispelon's avatar Baptiste Mispelon
Browse files

[1.7.x] Fixed #23156 -- Added missing BinaryField.deconstruct() method. 

Backport of 72f1eb48 from master.
parent 0b1d0afc

django/db/models/fields/__init__.py

+5 −0
Original line number Diff line number Diff line
@@ -2014,6 +2014,11 @@ class BinaryField(Field): 
        if self.max_length is not None:

            self.validators.append(validators.MaxLengthValidator(self.max_length))



    def deconstruct(self):

        name, path, args, kwargs = super(BinaryField, self).deconstruct()

        del kwargs['editable']

        return name, path, args, kwargs



    def get_internal_type(self):

        return "BinaryField"

tests/field_deconstruction/tests.py

+7 −0
Original line number Diff line number Diff line
@@ -364,3 +364,10 @@ class FieldDeconstructionTests(TestCase): 
        self.assertEqual(path, "django.db.models.URLField")

        self.assertEqual(args, [])

        self.assertEqual(kwargs, {"max_length": 231})



    def test_binary_field(self):

        field = models.BinaryField()

        name, path, args, kwargs = field.deconstruct()

        self.assertEqual(path, "django.db.models.BinaryField")

        self.assertEqual(args, [])

        self.assertEqual(kwargs, {})