Commit 20b598bf authored by Jacob Kaplan-Moss's avatar Jacob Kaplan-Moss
Browse files

Fixed #9989: fixed a subtle edge case where removing signals could break. Thanks, ferringb. 

git-svn-id: http://code.djangoproject.com/svn/django/trunk@10398 bcc190cf-cafb-0310-a4f2-bffc1f526a37
parent df7ffe61

django/dispatch/dispatcher.py

+4 −3
Original line number Diff line number Diff line
@@ -120,9 +120,10 @@ class Signal(object): 
        else:

            lookup_key = (_make_id(receiver), _make_id(sender))

        

        for idx, (r_key, _) in enumerate(self.receivers):

        for index in xrange(len(self.receivers)):

            (r_key, _) = self.receivers[index]

            if r_key == lookup_key:

                del self.receivers[idx]

                del self.receivers[index]



    def send(self, sender, **named):

        """Send signal from sender to all connected receivers.

tests/modeltests/signals/models.py

+11 −0
Original line number Diff line number Diff line
@@ -96,4 +96,15 @@ instance.id is None: False 
>>> models.signals.pre_delete.disconnect(pre_delete_test)

>>> models.signals.post_save.disconnect(post_save_test)

>>> models.signals.pre_save.disconnect(pre_save_test)



# Make sure all the signals got removed properly (#9989)

>>> models.signals.post_delete.receivers

[]

>>> models.signals.pre_delete.receivers

[]

>>> models.signals.post_save.receivers

[]

>>> models.signals.pre_save.receivers

[]



"""}