Commit 197dd4b8 authored by Tim Graham's avatar Tim Graham
Browse files

Prevented some test commands from needlessly running system checks. 

This is a performance optimization and also fixes test errors with the
upcoming merge of contrib tests into tests/. The tests failed on MySQL
because the models with GeometryField were being checked but the
non-GIS MySQL backend didn't know how to handle them.
parent 19188826

django/contrib/auth/tests/test_management.py

+2 −0
Original line number Diff line number Diff line
@@ -334,6 +334,7 @@ class CreatesuperuserManagementCommandTestCase(TestCase): 
        """

        sentinel = object()

        command = createsuperuser.Command()

        command.check = lambda: []

        command.execute(

            stdin=sentinel,

            stdout=six.StringIO(),
@@ -346,6 +347,7 @@ class CreatesuperuserManagementCommandTestCase(TestCase): 
        self.assertIs(command.stdin, sentinel)



        command = createsuperuser.Command()

        command.check = lambda: []

        command.execute(

            stdout=six.StringIO(),

            stderr=six.StringIO(),

tests/admin_scripts/tests.py

+1 −0
Original line number Diff line number Diff line
@@ -1577,6 +1577,7 @@ class CommandTypes(AdminScriptTestCase): 
        being executed (#21255).

        """

        command = BaseCommand(stderr=StringIO())

        command.check = lambda: []

        command.handle = lambda *args, **kwargs: args

        with mock.patch('django.core.management.base.connections') as mock_connections:

            command.run_from_argv(['', ''])

tests/user_commands/tests.py

+9 −1
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ from django.core import management 
from django.core.management import BaseCommand, CommandError, find_commands

from django.core.management.utils import find_command, popen_wrapper

from django.db import connection

from django.test import SimpleTestCase, ignore_warnings

from django.test import SimpleTestCase, ignore_warnings, override_settings

from django.test.utils import captured_stderr, captured_stdout, extend_sys_path

from django.utils import translation

from django.utils._os import upath
@@ -13,6 +13,14 @@ from django.utils.deprecation import RemovedInDjango20Warning 
from django.utils.six import StringIO





# A minimal set of apps to avoid system checks running on all apps.

@override_settings(

    INSTALLED_APPS=[

        'django.contrib.auth',

        'django.contrib.contenttypes',

        'user_commands',

    ],

)

class CommandTests(SimpleTestCase):

    def test_command(self):

        out = StringIO()