Commit 11d9cbe2 authored by Lee Sanghyuck's avatar Lee Sanghyuck Committed by Tim Graham
Browse files

Fixed #23316 -- Added datetime.time serialization in migrations.

parent ad9ba9d2

AUTHORS

+1 −0
Original line number Diff line number Diff line
@@ -545,6 +545,7 @@ answer newbie questions, and generally made Django that much better: 
    Bartolome Sanchez Salado <i42sasab@uco.es>

    Nick Sandford <nick.sandford@gmail.com>

    Mark Sandstrom <mark@deliciouslynerdy.com>

    Lee Sanghyuck <shlee322@elab.kr>

    Kadesarin Sanjek

    Tim Saylor <tim.saylor@gmail.com>

    Massimo Scamarcia <massimo.scamarcia@gmail.com>

django/db/migrations/writer.py

+4 −0
Original line number Diff line number Diff line
@@ -279,6 +279,10 @@ class MigrationWriter(object): 
            if isinstance(value, datetime_safe.date):

                value_repr = "datetime.%s" % value_repr

            return value_repr, set(["import datetime"])

        # Times

        elif isinstance(value, datetime.time):

            value_repr = repr(value)

            return value_repr, set(["import datetime"])

        # Settings references

        elif isinstance(value, SettingsReference):

            return "settings.%s" % value.setting_name, set(["from django.conf import settings"])

docs/topics/migrations.txt

+1 −1
Original line number Diff line number Diff line
@@ -524,7 +524,7 @@ Django can serialize the following: 


- ``int``, ``long``, ``float``, ``bool``, ``str``, ``unicode``, ``bytes``, ``None``

- ``list``, ``set``, ``tuple``, ``dict``

- ``datetime.date`` and ``datetime.datetime`` instances

- ``datetime.date``, ``datetime.time``, and ``datetime.datetime`` instances

- ``decimal.Decimal`` instances

- Any Django field

- Any function or method reference (e.g. ``datetime.datetime.today``)

tests/migrations/test_writer.py

+1 −0
Original line number Diff line number Diff line
@@ -95,6 +95,7 @@ class WriterTests(TestCase): 
        self.assertSerializedEqual(datetime.datetime.today)

        self.assertSerializedEqual(datetime.date.today())

        self.assertSerializedEqual(datetime.date.today)

        self.assertSerializedEqual(datetime.datetime.now().time())

        with self.assertRaises(ValueError):

            self.assertSerializedEqual(datetime.datetime(2012, 1, 1, 1, 1, tzinfo=get_default_timezone()))

        safe_date = datetime_safe.date(2014, 3, 31)