Commit 0cee3c0e authored by Aymeric Augustin's avatar Aymeric Augustin
Browse files

Updated a test that doesn't make sense with autocommit.

parent 423c0d5e
Loading
Loading
Loading
Loading
+15 −13
Original line number Diff line number Diff line
@@ -4,7 +4,7 @@ from django.db import connection, connections, transaction, DEFAULT_DB_ALIAS, Da
from django.db.transaction import commit_on_success, commit_manually, TransactionManagementError
from django.test import TransactionTestCase, skipUnlessDBFeature
from django.test.utils import override_settings
from django.utils.unittest import skipIf, skipUnless, expectedFailure
from django.utils.unittest import skipIf, skipUnless

from transactions.tests import IgnorePendingDeprecationWarningsMixin

@@ -187,12 +187,12 @@ class TestNewConnection(IgnorePendingDeprecationWarningsMixin, TransactionTestCa
            connections[DEFAULT_DB_ALIAS].close()
            connections[DEFAULT_DB_ALIAS] = self._old_backend

    # TODO: update this test to account for database-level autocommit.
    @expectedFailure
    def test_commit(self):
        """
        Users are allowed to commit and rollback connections.
        """
        connection.set_autocommit(False)
        try:
            # The starting value is False, not None.
            self.assertIs(connection._dirty, False)
            list(Mod.objects.all())
@@ -203,6 +203,8 @@ class TestNewConnection(IgnorePendingDeprecationWarningsMixin, TransactionTestCa
            self.assertTrue(connection.is_dirty())
            connection.rollback()
            self.assertFalse(connection.is_dirty())
        finally:
            connection.set_autocommit(True)

    def test_enter_exit_management(self):
        orig_dirty = connection._dirty