Commit 09188b50 authored by Baptiste Mispelon's avatar Baptiste Mispelon
Browse files

[1.8.x] Fixed #24566 -- Added support for serializing timedelta 

Thanks to knbk for the report.

Backport of 30a3c2f7 from master.
parent e7366ab1

django/db/migrations/writer.py

+3 −0
Original line number Diff line number Diff line
@@ -323,6 +323,9 @@ class MigrationWriter(object): 
            if isinstance(value, datetime_safe.time):

                value_repr = "datetime.%s" % value_repr

            return value_repr, {"import datetime"}

        # Timedeltas

        elif isinstance(value, datetime.timedelta):

            return repr(value), {"import datetime"}

        # Settings references

        elif isinstance(value, SettingsReference):

            return "settings.%s" % value.setting_name, {"from django.conf import settings"}

docs/releases/1.8.1.txt

+2 −1
Original line number Diff line number Diff line
@@ -9,4 +9,5 @@ Django 1.8.1 fixes several bugs in 1.8. 
Bugfixes

========



* ...
 
* Added support for serializing :class:`~datetime.timedelta` objects in

  migrations (:ticket:`24566`).

tests/migrations/test_writer.py

+5 −0
Original line number Diff line number Diff line
@@ -339,6 +339,11 @@ class WriterTests(TestCase): 
        self.assertSerializedEqual(FoodManager('a', 'b'))

        self.assertSerializedEqual(FoodManager('x', 'y', c=3, d=4))





    def test_serialize_timedelta(self):

        self.assertSerializedEqual(datetime.timedelta())

        self.assertSerializedEqual(datetime.timedelta(minutes=42))



    def test_simple_migration(self):

        """

        Tests serializing a simple migration.