Commit 07cfe1bd authored by Collin Anderson's avatar Collin Anderson Committed by Tim Graham
Browse files

Refs #14497 -- Handled empty readonly admin FileFields

parent 8ec306a3

django/contrib/admin/utils.py

+1 −1
Original line number Diff line number Diff line
@@ -388,7 +388,7 @@ def display_for_field(value, field): 
        return formats.number_format(value, field.decimal_places)

    elif isinstance(field, models.FloatField):

        return formats.number_format(value)

    elif isinstance(field, models.FileField):

    elif isinstance(field, models.FileField) and value:

        return mark_safe('<a href="%s">%s</a>' % (

            conditional_escape(value.url),

            conditional_escape(value),

tests/admin_widgets/tests.py

+6 −0
Original line number Diff line number Diff line
@@ -396,6 +396,12 @@ class AdminFileWidgetTests(DjangoTestCase): 
            '<input type="file" name="cover_art" id="id_cover_art" />',

            html=True,

        )

        response = self.client.get(reverse('admin:admin_widgets_album_add'))

        self.assertContains(

            response,

            '<p></p>',

            html=True,

        )





@override_settings(ROOT_URLCONF='admin_widgets.urls')