Commit 06f379bd authored by Jacob Kaplan-Moss's avatar Jacob Kaplan-Moss
Browse files

[1.0.X] Fixed #10753 -- Fixed regression in dispatcher after [10398]. Thanks... 

[1.0.X] Fixed #10753 -- Fixed regression in dispatcher after [10398]. Thanks for the patch and tests, minmax. Backport of r10497 from trunk.

git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.0.X@10503 bcc190cf-cafb-0310-a4f2-bffc1f526a37
parent 2ab40287

django/dispatch/dispatcher.py

+1 −0
Original line number Diff line number Diff line
@@ -124,6 +124,7 @@ class Signal(object): 
            (r_key, _) = self.receivers[index]

            if r_key == lookup_key:

                del self.receivers[index]

                break



    def send(self, sender, **named):

        """Send signal from sender to all connected receivers.

tests/regressiontests/dispatch/tests/test_dispatcher.py

+13 −0
Original line number Diff line number Diff line
@@ -103,6 +103,19 @@ class DispatcherTests(unittest.TestCase): 
        a_signal.disconnect(fails)

        self._testIsClean(a_signal)



    def testDisconnection(self):

        receiver_1 = Callable()

        receiver_2 = Callable()

        receiver_3 = Callable()

        a_signal.connect(receiver_1)

        a_signal.connect(receiver_2)

        a_signal.connect(receiver_3)

        a_signal.disconnect(receiver_1)

        del receiver_2

        garbage_collect()

        a_signal.disconnect(receiver_3)

        self._testIsClean(a_signal)



def getSuite():

    return unittest.makeSuite(DispatcherTests,'test')