Commit db097965 authored by Thomas Petazzoni's avatar Thomas Petazzoni Committed by Peter Korsgaard
Browse files

gdb: adjust behavior when thread debug is not available 

When an external toolchain without thread debug is used, the gdb
package can be selected, but no version can be choosen, since none
match any of the requirements. This leads Buildroot to try to build
gdb for the target without a version being defined, as in the
following build log:

 http://autobuild.buildroot.org/results/84e8fd2df0cc22448052a572c2e9a6e03dd137eb/build-end.log



To fix this, we adjust the dependencies of the BR2_PACKAGE_GDB option
so that the package as a whole is not selectable when the required
conditions are not met. Basically, we have the choice of:

 * Having a toolchain that supports thread debugging, which is needed
   for gdb >= 7.x

 * Having BR2_DEPRECATED enabled, which allows gdb 6.8 to be selected,
   which doesn't require thread debugging

 * Using bfin, since this architectures has a special old gdb version

Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: default avatarPeter Korsgaard <jacmet@sunsite.dk>
parent 1e9b9632

toolchain/gdb/Config.in

+9 −4
Original line number Diff line number Diff line
@@ -4,8 +4,14 @@ config BR2_PACKAGE_GDB 
	bool "Build gdb debugger for the Target"

	select BR2_PACKAGE_NCURSES

	depends on BR2_USE_WCHAR

	depends on BR2_TOOLCHAIN_HAS_THREADS

	depends on !BR2_sh && !BR2_sh64 && !BR2_avr32 && !BR2_microblaze

	# The newest versions of gdb require thread debugging in the

	# toolchain. The only cases for which this is not needed is if

	# we use gdb 6.8 (marked deprecated)

	depends on \

		BR2_TOOLCHAIN_HAS_THREADS_DEBUG_IF_NEEDED || \

		BR2_DEPRECATED || \

		BR2_bfin

	help

	    Build the full gdb debugger to run on the target.
@@ -90,9 +96,8 @@ choice 


endchoice



comment "gdb 7.x support needs pthread debug support in toolchain"

	depends on BR2_PACKAGE_GDB || BR2_PACKAGE_GDB_SERVER || BR2_PACKAGE_GDB_HOST

	depends on !BR2_TOOLCHAIN_HAS_THREADS_DEBUG_IF_NEEDED

comment "gdb support needs pthread debug support in toolchain"

	depends on !BR2_DEPRECATED && !BR2_bfin && !BR2_TOOLCHAIN_HAS_THREADS_DEBUG_IF_NEEDED



config BR2_GDB_VERSION

	string