Commit 8a98a7d9 authored by Thomas Petazzoni's avatar Thomas Petazzoni
Browse files

thrift: remove BR2_ARCH_HAS_ATOMICS dependency 



thrift builds perfectly fine on SPARC, which doesn't implement any of
the __sync built-ins, so we can get rid of the BR2_ARCH_HAS_ATOMICS
dependency.

The dependency on atomic operations originated in commit
1aaa14d8 ("thrift: disable for ARC"),
but there was no reference to any autobuilder failure. Our testing
with an ARC toolchain that doesn't have atomics shows that thrift
builds just fine, and code inspection also shows no usage of
__sync_*() built-ins. At the time of the commit, the thrift version
was 0.9.1, which also did not contain any __sync_*() call.

Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: default avatar"Yann E. MORIN" <yann.morin.1998@free.fr>
[yann.morin.1998@free.fr: build-tested on an ARC toolchain without
 atomics, with CPU 770D]
Acked-by: default avatar"Yann E. MORIN" <yann.morin.1998@free.fr>
parent 55dc90db

package/thrift/Config.in

+0 −2
Original line number Diff line number Diff line
@@ -3,7 +3,6 @@ config BR2_PACKAGE_THRIFT 
	depends on BR2_INSTALL_LIBSTDCPP

	depends on BR2_USE_WCHAR

	depends on BR2_TOOLCHAIN_HAS_THREADS

	depends on BR2_ARCH_HAS_ATOMICS

	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS

	select BR2_PACKAGE_BOOST

	select BR2_PACKAGE_LIBEVENT
@@ -20,7 +19,6 @@ config BR2_PACKAGE_THRIFT 
	  http://thrift.apache.org/



comment "thrift needs a toolchain w/ C++, wchar, threads"

	depends on BR2_ARCH_HAS_ATOMICS

	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS

	depends on !BR2_USE_WCHAR || \

		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP