Commit 84d79869 authored by Yann E. MORIN's avatar Yann E. MORIN Committed by Peter Korsgaard
Browse files

support/download: fix the bzr helper 



bzr uses the name of the extension of the output file to known what
output format to use: tar, tgz, tar.bz2... If no extension is
recognised, bzr will output to a directory.

Since we use 'mktemp .XXXXXX' to generate temporary files, it obviously
never ends with a recognised extension. Thus, bzr expects the output to
be a directory, and fails since it is a file.

Fix that by forcing the output format.

Signed-off-by: default avatar"Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: default avatarArnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: default avatarPeter Korsgaard <peter@korsgaard.com>
parent 1b301e8f

support/download/bzr

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ tmp_output="$( mktemp "${output}.XXXXXX" )" 
# - finally, we atomically rename to the final file



ret=1

if ${BZR} export "${tmp_dl}" "${repo}" -r "${rev}"; then

if ${BZR} export --format=tgz "${tmp_dl}" "${repo}" -r "${rev}"; then

    if mv "${tmp_dl}" "${tmp_output}"; then

        mv "${tmp_output}" "${output}"

        ret=0