Commit 81863eaf authored by Thomas Petazzoni's avatar Thomas Petazzoni Committed by Peter Korsgaard
Browse files

kodi, mpd: fix samba4 related dependency mistakes 



This commit fixes the following kconfig warning:

   warning: (BR2_PACKAGE_KODI_LIBSMBCLIENT && BR2_PACKAGE_MPD_LIBSMBCLIENT) selects BR2_PACKAGE_SAMBA4 which has unmet direct dependencies (!BR2_PACKAGE_SAMBA && BR2_USE_MMU && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_NATIVE_RPC && BR2_TOOLCHAIN_HAS_THREADS && !BR2_STATIC_LIBS && !BR2_nios2)

by updating the kodi and mpd Config.in files to properly take into
account the dependencies of the BR2_PACKAGE_SAMBA4 option that they
select.

Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: default avatarPeter Korsgaard <peter@korsgaard.com>
parent 85a28f39

package/kodi/Config.in

+3 −2
Original line number Diff line number Diff line
@@ -208,12 +208,13 @@ config BR2_PACKAGE_KODI_LIBSHAIRPLAY 
comment "shairport support needs a toolchain w/ dynamic library"

	depends on BR2_STATIC_LIBS



comment "samba support needs an (e)glibc toolchain"

	depends on !BR2_TOOLCHAIN_USES_GLIBC

comment "samba support needs an (e)glibc toolchain w/ RPC"

	depends on !BR2_TOOLCHAIN_USES_GLIBC || !BR2_TOOLCHAIN_HAS_NATIVE_RPC



config BR2_PACKAGE_KODI_LIBSMBCLIENT

	bool "samba"

	depends on BR2_TOOLCHAIN_USES_GLIBC

	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC

	select BR2_PACKAGE_SAMBA4

	help

	  Enable Samba support

package/mpd/Config.in

+6 −2
Original line number Diff line number Diff line
@@ -189,13 +189,17 @@ config BR2_PACKAGE_MPD_LIBNFS 
comment "nfs support needs a toolchain w/ threads support"

	depends on !(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC)



comment "samba support needs an (e)glibc toolchain"

	depends on !BR2_TOOLCHAIN_USES_GLIBC

comment "samba support needs an (e)glibc toolchain w/ dynamic library, RPC"

	depends on !BR2_nios2

	depends on !BR2_TOOLCHAIN_USES_GLIBC || BR2_STATIC_LIBS || \

		!BR2_TOOLCHAIN_HAS_NATIVE_RPC



config BR2_PACKAGE_MPD_LIBSMBCLIENT

	bool "samba"

	depends on !BR2_nios2 # samba

	depends on BR2_TOOLCHAIN_USES_GLIBC

	depends on !BR2_STATIC_LIBS

	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC

	select BR2_PACKAGE_SAMBA4

	help

	  Enable Samba support.