Commit 5c28f595 authored by Thomas Petazzoni's avatar Thomas Petazzoni Committed by Peter Korsgaard
Browse files

libv4l: properly error out when one of the make step fails 



In libv4l.mk, if there are multiple elements in $(LIBV4L_DIRS_y), they
are built in order, one after the other. However, our loop construct
doesn't take into account the fact that we should error out if one of
the steps failed.

A good illustration is having BR2_PACKAGE_LIBV4L_DECODE_TM6000 and
BR2_PACKAGE_LIBV4L_V4L2_CTL enabled. The build of decode-tm6000 will
fail, but the build will happily continue without stopping in libv4l.

Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: default avatarPeter Korsgaard <jacmet@sunsite.dk>
parent d3eced26

package/libv4l/libv4l.mk

+3 −3
Original line number Diff line number Diff line
@@ -24,19 +24,19 @@ endif 
define LIBV4L_BUILD_CMDS

	for i in $(LIBV4L_DIRS_y); do \

		$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)/$$i \

			$(LIBV4L_MAKE_OPTS); done

			$(LIBV4L_MAKE_OPTS) || exit 1 ; done

endef



define LIBV4L_INSTALL_STAGING_CMDS

	for i in $(LIBV4L_DIRS_y); do \

		$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)/$$i \

			DESTDIR=$(STAGING_DIR) $(LIBV4L_MAKE_OPTS) install; done

			DESTDIR=$(STAGING_DIR) $(LIBV4L_MAKE_OPTS) install || exit 1; done

endef



define LIBV4L_INSTALL_TARGET_CMDS

	for i in $(LIBV4L_DIRS_y); do \

		$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)/$$i \

			DESTDIR=$(TARGET_DIR) $(LIBV4L_MAKE_OPTS) install; done

			DESTDIR=$(TARGET_DIR) $(LIBV4L_MAKE_OPTS) install || exit 1; done

endef



$(eval $(generic-package))