This project is archived. Its data is read-only.

Commit 3dea23cf authored Jul 26, 2015 by Yann E. MORIN Committed by Thomas Petazzoni Jul 26, 2015

core/download: don't be needlessly verbose in backends

In 50c8b7e9 (support/download: support -q in all download backends), the
backend were made to respect the quietness of the main Makefile, when -s
is poassed on the 'make' command line. In doing so, they were all made
to be verbose by default.

However, the verbosity of some of the tools, like scp, is very high, and
is in fact intended for debug purposes.

Drop being verbose by default, just use whatever each tool deems normal
output. Only respect the quietness requested by the user.

Reported-by: Thomas De Schampheleire <patrickdepinguin@gmail.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

parent 889a4a8d

support/download/bzr

+1 −1

Original line number	Diff line number	Diff line
		@@ -12,7 +12,7 @@ set -e
		# BZR : the bzr command to call


		verbose=-v
		verbose=
		while getopts :q OPT; do
		case "${OPT}" in
		q) verbose=-q;;

support/download/cp

+5 −0

Original line number	Diff line number	Diff line
		@@ -11,7 +11,12 @@ set -e
		# Environment:
		# LOCALFILES: the cp command to call

		# 'cp' usually does not print anything on its stdout, whereas the
		# other download backends, even if not verbose, at least print some
		# progress information.
		# Make 'cp' verbose by default, so it behaves a bit like the others.
		verbose=-v

		while getopts :q OPT; do
		case "${OPT}" in
		q) verbose=;;

support/download/git

+1 −1

Original line number	Diff line number	Diff line
		@@ -11,7 +11,7 @@ set -e
		# Environment:
		# GIT : the git command to call

		verbose=-v
		verbose=
		while getopts :q OPT; do
		case "${OPT}" in
		q) verbose=-q; exec >/dev/null;;

support/download/hg

+1 −1

Original line number	Diff line number	Diff line
		@@ -11,7 +11,7 @@ set -e
		# Environment:
		# HG : the hg command to call

		verbose=-v
		verbose=
		while getopts :q OPT; do
		case "${OPT}" in
		q) verbose=-q;;

support/download/scp

+1 −1

Original line number	Diff line number	Diff line
		@@ -11,7 +11,7 @@ set -e
		# Environment:
		# SCP : the scp command to call

		verbose=-v
		verbose=
		while getopts :q OPT; do
		case "${OPT}" in
		q) verbose=-q;;