Commit 32753154 authored by Yann E. MORIN's avatar Yann E. MORIN Committed by Thomas Petazzoni
Browse files

support/download: always fail when there's no hash 



At the time we introduced hashes, we did not want to be too harsh in the
beginning, and give people some time to adapt and accept the hashes. So
we so far only whined^Wwarned about a missing hash (when the .hash file
exists).

Some time has passed now, and people are still missing updating hashes
when bumping packages.

Let's make that warning a little bit more annoying...

Signed-off-by: default avatar"Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
Reviewed-by: default avatarSamuel Martin <s.martin49@gmail.com>
Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
parent 3c19d511

docs/manual/adding-packages-directory.txt

+4 −4
Original line number Diff line number Diff line
@@ -475,10 +475,10 @@ not match, Buildroot considers this an error, deletes the downloaded file, 
and aborts.



If the +.hash+ file is present, but it does not contain a hash for a

downloaded file, no check is done for that file. If you set the

environment variable +BR2_ENFORCE_CHECK_HASH+ to a non-empty value, and

there is no hash for a downloaded file, Buildroot considers this an

error, deletes the downloaded file, and aborts.

downloaded file, Buildroot considers this an error and aborts. However,

the downloaded file is left in the download directory since this

typically indicates that the +.hash+ file is wrong but the downloaded

file is probably OK.



Sources that are downloaded from a version control system (git, subversion,

etc...) can not have a hash, because the version control system and tar

support/download/check-hash

+2 −6
Original line number Diff line number Diff line
@@ -94,10 +94,6 @@ while read t h f; do 
done <"${h_file}"



if [ ${nb_checks} -eq 0 ]; then

    if [ -n "${BR2_ENFORCE_CHECK_HASH}" ]; then

    printf "ERROR: No hash found for %s\n" "${base}" >&2

    exit 3

    else

        printf "WARNING: No hash found for %s\n" "${base}" >&2

    fi

fi