Commit 1a222542 authored by Thomas Petazzoni's avatar Thomas Petazzoni Committed by Peter Korsgaard
Browse files

samba4: remove dependency on specific C libraries 



samba4 relies on the $ORIGIN feature of the dynamic linker, which used
to not be implemented in old uClibc versions. However:

 - this feature is supported by glibc
 - this feature is supported by uClibc-ng, which is the only uClibc
   version we are going to support
 - this feature is supported by musl

Consequently, we can completely remove the dependency of samba4 on
certain C libraries.

Note that despite this commit, samba4 still cannot be chosen when the
musl C library is used, because samba4 requires native RPC support,
which musl doesn't provide.

Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: default avatarPeter Korsgaard <peter@korsgaard.com>
parent 0fed01a5

package/samba4/Config.in

+2 −5
Original line number Diff line number Diff line 
comment "samba4 needs an (e)glibc or uClibc-ng toolchain w/ RPC, wchar, dynamic library, threads"

	depends on (!BR2_TOOLCHAIN_USES_GLIBC && !BR2_UCLIBC_VERSION_NG) \

		|| !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_NATIVE_RPC \

comment "samba4 needs a toolchain w/ RPC, wchar, dynamic library, threads"

	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_NATIVE_RPC \

		|| BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS

	depends on BR2_USE_MMU
@@ -12,8 +11,6 @@ config BR2_PACKAGE_SAMBA4 
	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC

	depends on BR2_TOOLCHAIN_HAS_THREADS # python -> libffi

	depends on !BR2_STATIC_LIBS # python

	# needs $ORIGIN support

	depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_UCLIBC_VERSION_NG

	depends on !BR2_nios2 # binary too large, relocations don't fit

	select BR2_PACKAGE_E2FSPROGS

	select BR2_PACKAGE_POPT