Commit da3638eb authored by Alexander Narsudinov's avatar Alexander Narsudinov
Browse files

Fix the goroutine variable capturing in `removeObjectsOneByOne` 

This patch fixes classic golang for-loop variable capturing issue that
leeds to incorrect results in goroutines.

This is fixed in latest versions of golang, but this project uses go 1.15,
so it won't work as expected by an author.
parent 25401592

pkg/s3/client.go

+5 −5
Original line number Diff line number Diff line
@@ -197,15 +197,15 @@ func (client *s3Client) removeObjectsOneByOne(bucketName, prefix string) error { 


	for object := range objectsCh {

		guardCh <- 1

		go func() {

			err := client.minio.RemoveObject(client.ctx, bucketName, object.Key,

				minio.RemoveObjectOptions{VersionID: object.VersionID})

		go func(obj minio.ObjectInfo) {

			err := client.minio.RemoveObject(client.ctx, bucketName, obj.Key,

				minio.RemoveObjectOptions{VersionID: obj.VersionID})

			if err != nil {

				glog.Errorf("Failed to remove object %s, error: %s", object.Key, err)

				glog.Errorf("Failed to remove object %s, error: %s", obj.Key, err)

				removeErrors++

			}

			<- guardCh

		}()

		}(object)

	}

	for i := 0; i < parallelism; i++ {

		guardCh <- 1