Commit bfba0874 authored by Vitaliy Filippov's avatar Vitaliy Filippov
Browse files

Implement support for running geesefs OUTSIDE of the container using systemd... 

Implement support for running geesefs OUTSIDE of the container using systemd to not crash mountpoints when csi-s3 is upgraded or restarted
parent e8d63dfc

README.md

+5 −0
Original line number Diff line number Diff line
@@ -94,6 +94,7 @@ metadata: 
provisioner: ru.yandex.s3.csi

parameters:

  mounter: geesefs

  options: "--memory-limit 1000 --dir-mode 0777 --file-mode 0666"

  bucket: some-existing-bucket-name

```
@@ -124,6 +125,10 @@ You can check POSIX compatibility matrix here: https://github.com/yandex-cloud/g 
* Almost full POSIX compatibility

* Good performance for both small and big files

* Does not store file permissions and custom modification times

* By default runs **outside** of the csi-s3 container using systemd, to not crash

  mountpoints with "Transport endpoint is not connected" when csi-s3 is upgraded

  or restarted. Add `--no-systemd` to `parameters.options` of the `StorageClass`

  to disable this behaviour.



#### s3fs

deploy/kubernetes/csi-s3.yaml

+6 −0
Original line number Diff line number Diff line
@@ -108,6 +108,8 @@ spec: 
              mountPropagation: "Bidirectional"

            - name: fuse-device

              mountPath: /dev/fuse

            - name: systemd-control

              mountPath: /run/systemd

      volumes:

        - name: registration-dir

          hostPath:
@@ -124,3 +126,7 @@ spec: 
        - name: fuse-device

          hostPath:

            path: /dev/fuse

        - name: systemd-control

          hostPath:

            path: /run/systemd

            type: DirectoryOrCreate

go.mod

+2 −0
Original line number Diff line number Diff line
@@ -4,6 +4,8 @@ go 1.15 


require (

	github.com/container-storage-interface/spec v1.1.0

	github.com/coreos/go-systemd/v22 v22.5.0 // indirect

	github.com/godbus/dbus/v5 v5.0.4 // indirect

	github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b

	github.com/golang/protobuf v1.1.0 // indirect

	github.com/kubernetes-csi/csi-lib-utils v0.6.1 // indirect

go.sum

+4 −0
Original line number Diff line number Diff line 
github.com/container-storage-interface/spec v1.1.0 h1:qPsTqtR1VUPvMPeK0UnCZMtXaKGyyLPG8gj/wG6VqMs=

github.com/container-storage-interface/spec v1.1.0/go.mod h1:6URME8mwIBbpVyZV93Ce5St17xBiQJQY67NDsuohiy4=

github.com/coreos/go-systemd/v22 v22.5.0 h1:RrqgGjYQKalulkV8NGVIfkXQf6YYmOyiJKk8iXXhfZs=

github.com/coreos/go-systemd/v22 v22.5.0/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc=

github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=

github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=

github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

github.com/godbus/dbus/v5 v5.0.4 h1:9349emZab16e7zQvpmsbtjc18ykshndd8y2PG3sgJbA=

github.com/godbus/dbus/v5 v5.0.4/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA=

github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b h1:VKtxabqXZkF25pY9ekfRL6a582T4P37/31XEstQ5p58=

github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfUlaOkMMuAQtPIUF8ecWP5IEl/CR7VP2Q=

github.com/golang/protobuf v1.1.0 h1:0iH4Ffd/meGoXqF2lSAhZHt8X+cPgkfn/cb6Cce5Vpc=

pkg/driver/nodeserver.go

+1 −1
Original line number Diff line number Diff line
@@ -110,7 +110,7 @@ func (ns *nodeServer) NodePublishVolume(ctx context.Context, req *csi.NodePublis 
	if err != nil {

		return nil, err

	}

	if err := mounter.Mount(stagingTargetPath, targetPath); err != nil {

	if err := mounter.Mount(stagingTargetPath, targetPath, volumeID); err != nil {

		return nil, err

	}