Commit 55013c94 authored by Vitaliy Filippov's avatar Vitaliy Filippov
Browse files

Add 3 FIXMEs

parent a0cf78dc

pkg/driver/controllerserver.go

+1 −0
Original line number Diff line number Diff line
@@ -125,6 +125,7 @@ func (cs *controllerServer) DeleteVolume(ctx context.Context, req *csi.DeleteVol 
		return nil, fmt.Errorf("failed to initialize S3 client: %s", err)

	}



	// FIXME Don't delete the bucket if it existed initially

	var deleteErr error

	if prefix == "" {

		// prefix is empty, we delete the whole bucket

pkg/mounter/goofys.go

+1 −0
Original line number Diff line number Diff line
@@ -46,6 +46,7 @@ func (goofys *goofysMounter) Unstage(stageTarget string) error { 


func (goofys *goofysMounter) Mount(source string, target string) error {

	fullPath := fmt.Sprintf("%s:%s", goofys.meta.BucketName, goofys.meta.Prefix)

	// FIXME Add memory limits

	args := []string{

		"--endpoint", goofys.endpoint,

		"--region", goofys.region,

pkg/s3/client.go

+1 −0
Original line number Diff line number Diff line
@@ -168,6 +168,7 @@ func (client *s3Client) removeObjects(bucketName, prefix string) error { 
}



// will delete files one by one without file lock

// FIXME Delete in parallel (if we want to delete objects at all!)

func (client *s3Client) removeObjectsOneByOne(bucketName, prefix string) error {

	objectsCh := make(chan minio.ObjectInfo, 1)

	removeErrCh := make(chan minio.RemoveObjectError, 1)